Conversation
Use 4 space for indentation
Align values for 3 and 4 letter fields
{ on same line as record
Space after commas
Remove trailing spaces
|
@mac-kan, do you think we should include a macro for the archiver policy? |
kivel
left a comment
kivel
left a comment
There was a problem hiding this comment.
Please look at the comment of the first suggestion.
In my mind, there is no downside of having the info fields by default for all.
Happy to discuss the matter, though.
I'd say it's mandatory to have it as a MACRO, otherwise you need to tinker with the template all the time, which is not really in the spirit of a module. |
I'm not aware that info fields create error. To my best knowledge, they are metadata that's consumed by a service that's actively looking for them. You'll get errors if the service can't find them, though. |
- Fix minor bugs (missing quotes, unnecessary commands, etc) - Create ECMC_ARCHIVER_POLICY macro - Create configureArchiver.cmd
It is not used
cdn-lnk
force-pushed
the
archiver-info-tag
branch
from
e0f51cb to
ee3ed2c
Compare
|
Hi @kivel , |
| field(OOPT, "Transition To Non-zero") | ||
| field(OUT, "$(PREFIX)$(MOTOR_NAME)-MR-SyncTrgSeq PP") | ||
| record(calcout, "$(PREFIX)$(MOTOR_NAME)-MR-SyncTrgH2L") { | ||
| #field(PINI, "1") |
There was a problem hiding this comment.
If you're fixing the formatting here you could consider removing this (same in the following record def) - your call 🔧
|
Hi @anderssandstrom , please let me know if any changes are needed to get this merged. |
4 participants
Hi @kivel and @anderssandstrom,
The guys here at ESS recently released a new feature that allow us to automatically register PVs for archival using info tags.
This PR adds support to said info tags. This means all ecmc IOCs at ESS can (can, not will, see below) be archived by default.
Initially I am only adding this to the motor record PV.
In the future, depending on success and/or necessity, we may want to expand this to other PVs.
The behavior is disabled by default. It will only work if
NAMING == ESSnamingand the integrator specify the archiver cluster via theECMC_ARCHIVERvariable (currently only 3 options are availabletn,ninandlab).I believe I wrote the code in such way that should not affect other facilities and is easily expandable if necessary.
But please let me know your thoughts.
PS1: please do not merge before @mac-kan agrees with the changes.
PS2: I took the opportunity to fix the formatting of the motor record
.dbfiles.PS3: I think I found a bug (?): The way it stands right now
ECMC_AXISFIELDINIThas no effect.https://github.com/paulscherrerinstitute/ecmccfg/blob/master/motion/ecmc_axis_mr.cmd#L21-L22
PS4: I set up a virtual axis that has been constantly moving... It amounts to approx. 1.5 GB per year of data usage with
.RBVbeing the main culprit.